Open
Conversation
CheezItMan
reviewed
Oct 2, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Thanks for getting this in. Nice work, you hit all the learning goals here. Well done!
Comment on lines
+5
to
+6
| # Time Complexity: O(n * m log m) where m is the number of strings, and m is the length of a string | ||
| # Space Complexity: O(n * m) where n is the number of strings, and m is the length of a string (m space complexity from sort) |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n * k), where n is the length of the list and k is the number of common elements to return | ||
| # Space Complexity: O(n + k) where n is the length of the list and k is the number of common elements to return |
There was a problem hiding this comment.
Since you're building a hash of unique elements I would say that dominates the time complexity.
So O(m) where m is the number of unique elements.
Comment on lines
+92
to
+101
| counts = Hash.new(0) | ||
| (row_start...row_end).each do |row_index| | ||
| (col_start...col_end).each do |col_index| | ||
| char = table[row_index][col_index] | ||
| if char.to_i.to_s == char | ||
| counts[char] += 1 | ||
| return false if counts[char] > 1 | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Nice, although you might be able to reduce the complexity of this loop a bit by creating a method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions