Skip to content

Conversation

@lbristol88
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? You can do many things at once.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? When you click the get trips button, it will go collect the trips asynchronously so you can enter in data on the add trip form while it's fetching trips.
What kind of errors might the API give you? How did you choose to handle them? If you don't fully complete a form, you will receive an error because the API cannot complete it's post request. I display an error message to the user to see what fields are required for the form.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. It would be better to make the list of trips into a hash with the ID as the keys. Otherwise, if you wanted to keep it as a list, it is better to sort it by ID.

@tildeee
Copy link

tildeee commented Dec 12, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Functionality
Click a button to load and view a list of trips x
Click a trip to load and view trip details x
Fill out a form to reserve a spot x
Errors are reported to the user x
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Great work Layla! I like this project submission. Your code looks good and does a great job with the requirements. It has good clean style.

I have no issues or comments on anything specific, I think you did a great job on this! Well done!

const oneTrip = $(`<li>${trip.name}</li>`)
tripList.append(oneTrip);

oneTrip.on('click', () => {getOneTrip(`${trip.id}`)});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants