Performance improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These resulted in dramatic performance improvements in our usage. The biggest gain was from using a lookup table to avoid computing `exp` as often. Alas, I don't have exact benchmark numbers handy. The specific speedups are: * Use a lookup table for powers of bytes * Use murmur3 hash instead of md5 * Short-circuit estimateSize when we can skip many powers
|
|
Author
|
Thanks for this useful library! I used it in a case where I was computing many intersections, so I needed to speed up some of the computations, and I thought it would be helpful to contribute back my speedups. I hope they prove helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These resulted in dramatic performance improvements in our usage. The
biggest gain was from using a lookup table to avoid computing
expasoften. Alas, I don't have exact benchmark numbers handy.
The specific speedups are: