Merge feature/13 into master: Add Exception handling during Register, Resolve, Service Install #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strowy
approved these changes
Apr 19, 2022
Strowy
left a comment
Strowy
left a comment
There was a problem hiding this comment.
Spelling and whitespace notes, other than that seems ok.
stevehalliwell
force-pushed
the
feature/13_handle-exceptions
branch
from
6893e9e to
1d2557d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds exceptions and test around exceptions being through by services when they are created, by dependents when they are injected. Also provides a formalised way to dealing with an exception occurring during the container registration phase within the ServiceInstaller.
Closes
closes #13
Details
(#13) Add Exception handling during Register, Resolve, Service Install