feat: add a dynamic period to the high uncategorized time notification#745
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 1e14657 in 7 seconds. Click for details.
- Reviewed
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_0fKRn9u7kbLmWPXT
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile OverviewGreptile SummaryThis PR makes the uncategorized time notification message dynamic by displaying the correct time period (e.g., "this week", "the last 7 days") based on the selected view, instead of always showing "today". The implementation adds a Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Activity.vue
participant UncategorizedNotification.vue
participant ActivityStore
User->>Activity.vue: Select period (day/week/month/etc)
Activity.vue->>Activity.vue: Update periodLength prop
Activity.vue->>UncategorizedNotification.vue: Pass periodLength prop
UncategorizedNotification.vue->>UncategorizedNotification.vue: Compute periodText from periodLength
UncategorizedNotification.vue->>ActivityStore: Get uncategorizedDuration
ActivityStore-->>UncategorizedNotification.vue: Return [uncategorized, total]
UncategorizedNotification.vue->>User: Display notification with dynamic period text
|
|
Nice, thanks! :D |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 26.08% 26.08%
=======================================
Files 29 29
Lines 1698 1698
Branches 294 294
=======================================
Hits 443 443
Misses 1233 1233
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey team! Thanks for the ActivityWatch system.
In the activity panel there is an uncategorized time notification, hinting us to use the Category Builder. I noticed that it didn't change when you swapped to the other views (weekly, monthly, 7 days, etc.). Thus, it will always state: "... of all time today".
Old (for weekly view):
New (for weekly view):
I've made the required changes. Let me know if you'd like it to be structured / implemented differently.
Important
Dynamic period text added to
UncategorizedNotification.vuebased onperiodLengthprop fromActivity.vue.UncategorizedNotification.vueto dynamically display period text based onperiodLengthprop.Activity.vueto passperiodLengthtoaw-uncategorized-notificationcomponent.periodLengthprop toUncategorizedNotification.vuewith default 'day'.periodTextinUncategorizedNotification.vueto mapperiodLengthto readable text.This description was created by
for 1e14657. You can customize this summary. It will automatically update as commits are pushed.