Open
Conversation
ErikBjare
changed the title
ErikBjare
commented
Jan 24, 2026
| b-dropdown-item(to="/search") | ||
| icon(name="search") | ||
| | Search | ||
| b-dropdown-item(to="/work-report") |
Member
Author
There was a problem hiding this comment.
Maybe just rename to /report?
Edit: oh, that already exists...
Contributor
Greptile OverviewGreptile SummaryAdded a new Work Report view that allows users to generate work time reports filtered by hosts, categories, and date ranges with CSV/JSON export capabilities. Key Changes:
Critical Issues:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant WR as WorkReport.vue
participant CS as CategoryStore
participant BS as BucketsStore
participant SS as SettingsStore
participant C as AWClient
participant S as AW Server
U->>WR: Navigate to /work-report
activate WR
WR->>CS: load categories
WR->>BS: ensureLoaded()
BS-->>WR: return buckets
WR->>WR: Auto-select all hosts
WR-->>U: Display form (hosts, categories, break time, date range)
deactivate WR
U->>WR: Click "Calculate Work Time"
activate WR
WR->>SS: Get startOfDay offset
SS-->>WR: "04:00"
WR->>WR: getTimeperiods() - Build date ranges
WR->>CS: Get classes_for_query
CS-->>WR: Category rules
WR->>WR: Build multi-device query with flood + categorize + filter_keyvals
loop For each timeperiod
WR->>C: query(timeperiod, query_string)
C->>S: POST /api/0/query
S-->>C: Query results (events, duration)
C-->>WR: Query results
end
WR->>WR: Process results into dailyData
WR-->>U: Display daily breakdown table
deactivate WR
U->>WR: Click "Export CSV" or "Export JSON"
activate WR
WR->>WR: Format data as CSV/JSON
WR->>U: Download file
deactivate WR
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
252
to
260
| const offset = this.settingsStore.startOfDay; | ||
|
|
||
| const timeperiods = []; | ||
|
|
||
| if (this.dateRange === 'last7d') { | ||
| for (let i = 6; i >= 0; i--) { | ||
| const start = moment().subtract(i, 'days').startOf('day').add(offset); | ||
| const end = start.clone().add(1, 'day'); | ||
| timeperiods.push(start.format() + '/' + end.format()); |
Contributor
There was a problem hiding this comment.
offset is a string (format "04:00") but is being passed directly to moment().add() which expects a number.
Parse the offset properly:
Suggested change
| const offset = this.settingsStore.startOfDay; | |
| const timeperiods = []; | |
| if (this.dateRange === 'last7d') { | |
| for (let i = 6; i >= 0; i--) { | |
| const start = moment().subtract(i, 'days').startOf('day').add(offset); | |
| const end = start.clone().add(1, 'day'); | |
| timeperiods.push(start.format() + '/' + end.format()); | |
| const offset = this.settingsStore.startOfDay; | |
| const [hours, minutes] = offset.split(':'); | |
| const offsetDuration = { hours: parseInt(hours), minutes: parseInt(minutes) }; | |
| const timeperiods = []; | |
| if (this.dateRange === 'last7d') { | |
| for (let i = 6; i >= 0; i--) { | |
| const start = moment().subtract(i, 'days').startOf('day').add(offsetDuration); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/views/WorkReport.vue
Line: 252:260
Comment:
`offset` is a string (format "04:00") but is being passed directly to `moment().add()` which expects a number.
Parse the offset properly:
```suggestion
const offset = this.settingsStore.startOfDay;
const [hours, minutes] = offset.split(':');
const offsetDuration = { hours: parseInt(hours), minutes: parseInt(minutes) };
const timeperiods = [];
if (this.dateRange === 'last7d') {
for (let i = 6; i >= 0; i--) {
const start = moment().subtract(i, 'days').startOf('day').add(offsetDuration);
```
How can I resolve this? If you propose a fix, please make it concise.| timeperiods.push(start.format() + '/' + end.format()); | ||
| } | ||
| } | ||
| // TODO: Add other date ranges |
Contributor
There was a problem hiding this comment.
only 'last7d' and 'last30d' are implemented, but 'thisWeek', 'thisMonth', and 'custom' date range options are presented to users without corresponding logic
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/views/WorkReport.vue
Line: 269:269
Comment:
only 'last7d' and 'last30d' are implemented, but 'thisWeek', 'thisMonth', and 'custom' date range options are presented to users without corresponding logic
How can I resolve this? If you propose a fix, please make it concise.![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 8274a00 in 2 minutes and 30 seconds. Click for details.
- Reviewed
387lines of code in3files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/components/Header.vue:62
- Draft comment:
Consider adding active state styling for the new ‘Work Report’ dropdown item to match the behavior of other navigation items. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/route.js:70
- Draft comment:
The WorkReport route is correctly lazy‐loaded and added. Ensure its placement/order remains consistent with similar routes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/views/WorkReport.vue:190
- Draft comment:
The regex replacement on the JSON string for categories (replace(/\\/g, '')) may be brittle; verify it correctly handles all expected input cases. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment suggests verifying the regex replacement, which is not allowed as it asks the author to ensure the behavior is intended. It doesn't provide a specific suggestion or ask for a test to be written. Therefore, it should be removed.
4. src/views/WorkReport.vue:174
- Draft comment:
Using alert() for notifying the user when no hosts are selected is less user-friendly; consider using a UI notification component. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
5. src/views/WorkReport.vue:302
- Draft comment:
In exportJSON the selectedCategories are exported as JSON strings; consider converting them back to their original structure for clarity in the exported data. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
6. src/views/WorkReport.vue:192
- Draft comment:
Consider refactoring the query-building logic inside loadData into a separate helper function to improve maintainability and readability. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_o7I3kXQusYv60oWO
You can customize 
| } | ||
| }, | ||
|
|
||
| getTimeperiods() { |
Contributor
There was a problem hiding this comment.
The UI offers several date range options (e.g. 'thisWeek', 'thisMonth', and 'custom'), but getTimeperiods only handles 'last7d' and 'last30d'. Consider implementing support for the remaining options or disabling them in the UI.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 26.08% 26.07% -0.02%
==========================================
Files 29 29
Lines 1698 1699 +1
Branches 307 307
==========================================
Hits 443 443
- Misses 1192 1234 +42
+ Partials 63 22 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed ec8e85c in 1 minute and 29 seconds. Click for details.
- Reviewed
227lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/views/WorkReport.vue:100
- Draft comment:
Unnecessary whitespace changes here; consider using a consistent auto-formatter (e.g., Prettier) to avoid noise in diffs. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/views/WorkReport.vue:200
- Draft comment:
The JSON.stringify() interpolation was split into multiple lines, which can hurt readability. Consider keeping it inline. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. src/views/WorkReport.vue:196
- Draft comment:
For consistency and security, use the sanitized variable (safeHost) in the find_bucket call instead of the unsanitized hostname. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_0BNsIrewdWlmLj20
You can customize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds a new work report view with export options and integrates it into the navigation and routing.
WorkReport.vuefor generating work time reports with options for hosts, categories, break time, and date range.Header.vue.briefcaseicon inHeader.vue./work-reportinroute.js.This description was created by
for ec8e85c. You can customize this summary. It will automatically update as commits are pushed.