[macos] Improve handling of missing application attributes

[amsam0]

This PR tries to fix at least 1 crash in the macOS swift implementation.

As described in ActivityWatch/aw-qt#103, a custom GTK application I wrote was previously ignored since it didn't have a bundle ID. It is now correctly recognized, and a few other possible crash points have been fixed. However, I have been unable to replicate the crashing I used to experience (it may have already been fixed).

Related: #101, #74, #100

---

Important

Fixes crash in macOS Swift by handling missing bundle identifiers and improving error handling for Chrome and Safari in macos.swift.

• Behavior:
  • Fixes crash by using localizedName or bundleIdentifier for application name in MainThing.windowTitleChanged().
  • Adds error handling for missing bundleIdentifier in Chrome and Safari sections in MainThing.windowTitleChanged().
  • Improves error logging for failed window/tab data extraction in Chrome and Safari.
• Misc:
  • Minor formatting change in debug() function condition.

^{This description was created by for 58dcb87. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 58dcb87 in 19 seconds

More details

• Looked at 118 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. aw_watcher_window/macos.swift:332

• Draft comment:
  Avoid force unwrapping with SBApplication.init(bundleIdentifier: bundleIdentifier)!. Consider using optional binding to safely handle potential nil values.
• Reason this comment was not posted:
  Comment was on unchanged code.

2. aw_watcher_window/macos.swift:367

• Draft comment:
  Avoid force unwrapping with SBApplication.init(bundleIdentifier: bundleIdentifier)!. Consider using optional binding to safely handle potential nil values.
• Reason this comment was not posted:
  Marked as duplicate.

3. aw_watcher_window/macos.swift:355

• Draft comment:
  Consider using debug or log instead of error for logging tab title differences, as this might not be an error condition.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error logging for tab title differences is using error level, which might not be appropriate for this kind of information. It could be more suitable to use debug or log level instead.

4. aw_watcher_window/macos.swift:385

• Draft comment:
  Consider using debug or log instead of error for logging tab title differences, as this might not be an error condition.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error logging for tab title differences is using error level, which might not be appropriate for this kind of information. It could be more suitable to use debug or log level instead.

Workflow ID: wflow_qHWQnQn7IDXBftuy

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[amsam0]

@ErikBjare any chance of this getting merged?

[amsam0]

@ErikBjare sorry to bother you, are there any changes you'd like me to make before it can be merged?

[Randaw366]

@ErikBjare I'm wondering too; will this ever get merged? If you could do it, it would be great, as I experience the same issue.

[amsam0]

You're probably better off just building it from source with my changes, unfortunately.