Skip to content

Conversation

@evopls
Copy link
Contributor

@evopls evopls commented Sep 4, 2025

When requesting audio_features the watcher doesn't run at all since the feature was removed from the Spotify API entirely.

Removing the request makes it run again just fine, it seems the feature was only used to request "id" specifically.

See: https://developer.spotify.com/documentation/web-api/reference/get-audio-features


Important

Removes deprecated audio_features API call in data_from_track() to ensure watcher runs without errors.

  • Behavior:
    • Removes call to sp.audio_features(track["item"]["id"]) in data_from_track() in main.py.
    • Ensures watcher runs without errors by not using deprecated Spotify API endpoint.
  • Misc:
    • Updates logic to handle tracks without using audio_features.

This description was created by Ellipsis for 5eeb828. You can customize this summary. It will automatically update as commits are pushed.

When requesting audio_features the watcher doesn't run at all since the feature was removed from the Spotify API entirely.

Removing the request makes it run again just fine, it seems the feature was only used to request ``"id"`` specifically.

See: https://developer.spotify.com/documentation/web-api/reference/get-audio-features
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 5eeb828 in 1 minute and 14 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw_watcher_spotify/main.py:40
  • Draft comment:
    There's a minor spacing issue on this line. It might be clearer to have a space after the else keyword (i.e., else {} instead of else{}), which improves readability.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about Python style conventions, this is an extremely minor formatting issue. Such minor style issues are typically better handled by automated formatters like black or pylint. The comment doesn't point out any functional issues or suggest meaningful improvements to the code quality. The spacing issue could potentially affect code readability. Some might argue that consistent formatting is important for maintainability. While consistent formatting is important, this is too minor to warrant a PR comment. This kind of feedback should be handled by automated tools rather than manual review comments. Delete this comment as it addresses an extremely minor formatting issue that would be better handled by automated formatting tools.

Workflow ID: wflow_zDnzHCgkI7Dh2vGp

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@ErikBjare ErikBjare merged commit a134078 into ActivityWatch:master Sep 8, 2025
1 check failed
@ErikBjare
Copy link
Member

Thanks @evopls!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants