Add build scripts for windows and linux#37
Open
Mourtz wants to merge 1 commit intoActivityWatch:masterfrom
Open
Add build scripts for windows and linux#37Mourtz wants to merge 1 commit intoActivityWatch:masterfrom
Mourtz wants to merge 1 commit intoActivityWatch:masterfrom
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to bc3869c in 1 minute and 52 seconds. Click for details.
- Reviewed
169lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. visualization/scripts/build.ps1:18
- Draft comment:
Consider wrapping external command calls (e.g., browserify and pug) in try/catch blocks for more robust error handling. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. visualization/scripts/build.sh:63
- Draft comment:
Normalize the input command (e.g., using 'tr' to convert to lower-case) so that the case of the command argument is ignored, similar to the PowerShell implementation. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While case-insensitive command matching could be user-friendly, it's not a critical issue. Build scripts typically expect exact command matches, and the help message shows the exact commands to use. The suggestion is a nice-to-have but not essential improvement. There's no evidence of user confusion or problems with the current approach. The suggestion could improve user experience by being more forgiving of capitalization. Unix commands are traditionally case-sensitive, so this deviates from convention. The benefit is minor and the current behavior follows Unix conventions. The help message clearly shows the expected commands. This comment should be removed as it suggests a non-essential change that deviates from Unix conventions without strong justification.
3. visualization/scripts/build.sh:21
- Draft comment:
Although 'set -e' ensures the script exits on errors, consider explicitly checking and reporting exit statuses for commands like browserify and pug to provide clearer feedback, aligning with the PowerShell script's approach. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_f4GsoF3Z1JoCIQtx
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add build scripts
build.ps1for Windows andbuild.shfor Unix/Linux to automate project building and cleaning.build.ps1for Windows using PowerShell.build.shfor Unix/Linux using Bash.distdirectory if it doesn't exist.bundle.jsusingbrowserifyandindex.htmlusingpug.build,clean, andhelpcommands.browserifyorpugis not found.This description was created by
for bc3869c. You can customize this summary. It will automatically update as commits are pushed.