chore: update dependencies#10
Merged
ErikBjare merged 1 commit intoActivityWatch:masterfrom Feb 21, 2025
Merged
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bfc2e10 in 1 minute and 36 seconds
More details
- Looked at
100lines of code in3files - Skipped
1files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. .github/workflows/build.yml:33
- Draft comment:
Removing the fixed poetry version may introduce build inconsistencies if a new release behaves differently. Consider pinning a specific version. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is about a dependency change, specifically the removal of a fixed version for a dependency management tool (poetry). The comment suggests pinning a specific version to avoid build inconsistencies. This falls under the rule of not commenting on dependency changes or library versions, as it doesn't provide a specific code suggestion or ask for a test to be written.
2. aw_notify/main.py:169
- Draft comment:
Using run_until_complete in notify() may conflict if an event loop is already running. Ensure this sync call won’t be invoked from an async context. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. .github/workflows/build.yml:33
- Draft comment:
Using 'pip install poetry' without pinning may lead to unstable builds if a future version introduces breaking changes. Consider using a specific version. - Reason this comment was not posted:
Marked as duplicate.
4. aw_notify/main.py:169
- Draft comment:
Calling run_until_complete on an event loop from get_running_loop may raise an error if a loop is already running. Consider using asyncio.run (or ensure notify is only called in sync contexts). - Reason this comment was not posted:
Marked as duplicate.
5. pyproject.toml:18
- Draft comment:
The dependency desktop-notifier has been updated to ^6.0.0; ensure that all necessary API migration changes (e.g. using Icon and async send) are fully tested and compatible across platforms. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is about a dependency update and suggests ensuring compatibility and testing, which violates the rules against commenting on dependency changes and asking for confirmation or testing.
Workflow ID: wflow_1UZAUPBIRyX6FO1y
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Member
|
Nice! Great to see the desktop-notifier update :) Did you get icons to work? I guess it might have worked for you before the update too if you're running an older version of macOS? |
Contributor
Author
|
The icon is now working, if I remember correctly :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependencies wasn't updated in a while, now it works (at least on my computer :D)
Important
Update dependencies, GitHub Actions workflow, and adjust code for compatibility with new versions.
aw-clientto^0.5.15anddesktop-notifierto^6.0.0inpyproject.toml.rubicon-objcto^0.5.0fordarwinplatform inpyproject.toml.pyinstallerto^6.12.0inpyproject.toml.osmatrix toubuntu-latest,windows-latest,macOS-latestinbuild.yml.python_versionto3.13inbuild.yml.actions/checkouttov4andactions/setup-pythontov5inbuild.yml.poetryversion pinning inbuild.yml.Iconclass forapp_iconinDesktopNotifierinmain.py.notify()inmain.py.This description was created by
for bfc2e10. It will automatically update as commits are pushed.