Fixed cache dir path on Windows. #3801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
force-pushed
the
mitchell/cp-1289
branch
from
e7a6373 to
3aae73f
Compare
mitchell-as
commented
Jan 5, 2026
Comment on lines
+129
to
+130
| rcfile, err := subshell.New(cfg).RcFile() | ||
| suite.NoError(err) |
Collaborator
Author
There was a problem hiding this comment.
There has been a compile error on the v48 branch all this time. I'm finally fixing it here.
Collaborator
Author
|
Test failures are sporadic and unrelated to this PR. |
MDrakos
approved these changes
Jan 6, 2026
mitchell-as
added a commit
that referenced
this pull request
Jan 6, 2026
Fixed cache dir path on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change last year accidentally made the cache directory the app directory. As a result,
state clean cachewould end up trying to delete the entire app directory. This failed because state-svc.exe and state.exe were in use, but the damage had already been done and an app re-install is needed.If we had QA on the v0.48.0 release, we would have caught this.