Skip to content

check result from redis.Redis.get() before escaping #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yolabingo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check result from redis.Redis.get() before escaping #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc7d91
check result from redis.Redis.get() before escaping
yolabingo Apr 16, 2015
9575c62
Don't overwrite keys. Fix typos.
yolabingo Apr 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import random
import string
import os
import types

host = "https://secrets-accp.mendix.com"
r = redis.Redis()
Expand Down Expand Up @@ -34,7 +35,8 @@ def create():
generated = True
else:
generated = False
r.set(key, secret)
while not r.setnx(key, secret):
key = random_string(redis_key_length)
secret_url = "%s/get/%s" % (host, key)

if generated:
Expand All @@ -56,8 +58,10 @@ def generate():

@app.route("/get/<key>")
def retrieve(key=None):
secret = escape(r.get(key))
secret = r.get(key)
r.delete(key)
if type(secret) != types.NoneType:
secret = escape(secret)
return render_template('get.tmpl', secret=secret)

if __name__ == "__main__":
Expand Down