Remove unused code that prevented compilation#16
Open
ReallyNiceGuy wants to merge 1 commit intoAcheronVM:masterfrom
Open
Remove unused code that prevented compilation#16ReallyNiceGuy wants to merge 1 commit intoAcheronVM:masterfrom
ReallyNiceGuy wants to merge 1 commit intoAcheronVM:masterfrom
Conversation
Owner
|
Ah, I had been using a locally modified version of the cc65 suite, so I hadn't noticed if the mainline one changed incompatibly. I'll check it out and merge this in soon. Thanks! |
Author
|
If you need anything else, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using .include inside a macro resolves the included file at definition time.
The removed code was assuming (correctly for an older version of ca65), that the include was being resolved at usage time.
As this code now breaks compilation, it must be removed. It wasn't being used anyways.