Skip to content

Conversation

@LordLuceus
Copy link
Collaborator

Summary

  • Restore Board_Prefix patch to capture dialogue that other hooks miss (e.g., when dialogue advances quickly without showing arrows)
  • Add IsInStaleDialogueMode() check to prevent announcing stale text when in court record, evidence details, or 3D evidence modes
  • Add continuation detection: when animations pause mid-sentence, announce only the new portion instead of repeating the full line

Problem

Some dialogue lines were being skipped entirely because they didn't trigger the arrow or guide icon hooks. Restoring Board_Prefix fixes this, but it previously caused issues with:

  1. Stale dialogue being re-announced when opening court record/evidence
  2. Partial dialogue being announced, then the full line repeated

Solution

  • Board_Prefix now checks IsInStaleDialogueMode() to skip capture when viewing court record, evidence details, or 3D evidence
  • New continuation detection in TryOutputDialogue() compares new text against previously announced text - if the new text starts with what was already said, only the new portion is announced

Before: "And when I awoke..." → "And when I awoke... stabbing Mystic Elise!"
After: "And when I awoke..." → "stabbing Mystic Elise!"

Test plan

  • Verify previously-skipped dialogue in GS1 Episode 1 is now announced
  • Verify dialogue with mid-sentence animation pauses announces partial then continuation (not full repeat)
  • Verify opening court record during dialogue doesn't re-announce stale text
  • Verify presenting evidence after viewing details doesn't re-announce stale text

🤖 Generated with Claude Code

- Restore Board_Prefix patch to capture dialogue that other hooks miss
  (e.g., when dialogue advances quickly without arrows)
- Add IsInStaleDialogueMode() check to prevent announcing stale text
  when in court record, evidence details, or 3D evidence modes
- Add continuation detection: when animations pause mid-sentence,
  announce only the new portion instead of repeating the full line

This improves the dialogue experience when animations interrupt text:
- Before: "And when I awoke..." then "And when I awoke... stabbing!"
- After: "And when I awoke..." then "stabbing!"

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@LordLuceus LordLuceus merged commit 7019d54 into master Jan 13, 2026
2 checks passed
@LordLuceus LordLuceus deleted the fix/dialogue-fixes branch January 13, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants