fix: Fix Korean missing highlighted text #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates MelonAccessibilityLib to version 1.1.1 which contains a fix for the GenericTagRegex that was incorrectly stripping Korean highlighted text in angle brackets. Fixes #14 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GenericTagRegexthat was incorrectly stripping Korean highlighted textRoot Cause
Korean text marks highlighted keywords with full-width angle brackets (
＜keyword＞). The game'sEnToHalf()function converts these to regular brackets (<keyword>), which theGenericTagRegexpattern<[^>]+>then matched and removed as if they were HTML tags.Fix
MelonAccessibilityLib v1.1.1 updates the regex to
</?[a-zA-Z][^>]*>which only matches actual Unity rich text tags (that start with ASCII letters), preserving Korean text in angle brackets.Test plan
Fixes #14
🤖 Generated with Claude Code