feat: Add window-based constructor to macOS subclassing adapter#253
Merged
mwcampbell merged 2 commits intomainfrom Jun 23, 2023
Merged
feat: Add window-based constructor to macOS subclassing adapter#253mwcampbell merged 2 commits intomainfrom
mwcampbell merged 2 commits intomainfrom
Conversation
DataTriny
reviewed
Jun 21, 2023
Member
DataTriny
left a comment
There was a problem hiding this comment.
Are you sure we won't need a similar function on the regular Adapter?
Contributor
Author
|
I've chosen not to add a similar function on the regular adapter because the assumption is that if a user is using the regular (non-subclassing) adapter, then they're implementing their own |
DataTriny
approved these changes
Jun 23, 2023
Merged
lunixbochs
pushed a commit
to talonvoice/accesskit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This easily solves the issue we're having with #250, where we'd otherwise have to either write a little Objective-C or do some low-level stuff with the ObjC runtime from C code to make the SDL example compile on macOS. It might also help some Rust users, which is why I implemented the alternate constructor in the platform adapter itself.