Skip to content

Use chartutil to process requirements#18

Open
amir wants to merge 2 commits intoAcalephStorage:developfrom
amir:release-values
Open

Use chartutil to process requirements#18
amir wants to merge 2 commits intoAcalephStorage:developfrom
amir:release-values

Conversation

@amir
Copy link

@amir amir commented Apr 29, 2018

This PR adds necessary requirements processing to InstallRelease.

Before this PR, following request will dispatch mariadb as a dependency to Tiller by following command:

curl -v -H "Content-type: application/json" -d '{"repo":"stable", "namespace": "default", "chart": "wordpress", "version": "0.8.7", "values": {"mariadb": {"enabled": false}, "externalDatabase": {"password": "password", "rootPassword": "password"}}}' localhost:5000/api/v1/releases

Even though mariadb is explicitly disabled using values.

This PR uses chartutil to exclude disabled dependencies and also imports values from child to parent.

@hunter hunter requested a review from darkcrux April 30, 2018 03:13
@imduffy15
Copy link

This looks good to me. @darkcrux any reason to not merge?

@amir
Copy link
Author

amir commented Apr 30, 2019

@imduffy15 I ended up creating https://github.com/amir/skeg which if I remember correctly kinda works as-is. During developing that I discovered a few issues such as helm/helm#4106 which you should to be aware of (that one hasn't been merged yet either).

@imduffy15
Copy link

Nice! Thanks for sharing @amir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants