Use chartutil to process requirements#18
Open
amir wants to merge 2 commits intoAcalephStorage:developfrom
Open
Use chartutil to process requirements#18amir wants to merge 2 commits intoAcalephStorage:developfrom
amir wants to merge 2 commits intoAcalephStorage:developfrom
Conversation
|
This looks good to me. @darkcrux any reason to not merge? |
Author
|
@imduffy15 I ended up creating https://github.com/amir/skeg which if I remember correctly kinda works as-is. During developing that I discovered a few issues such as helm/helm#4106 which you should to be aware of (that one hasn't been merged yet either). |
|
Nice! Thanks for sharing @amir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds necessary requirements processing to InstallRelease.
Before this PR, following request will dispatch
mariadbas a dependency to Tiller by following command:Even though
mariadbis explicitly disabled usingvalues.This PR uses
chartutilto exclude disabled dependencies and also imports values from child to parent.