feat(core): Add flexible signature mocking to support Cumulus inherents #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mockSignatureHost` option has been enhanced from a simple boolean to a tri-state numeric value, offering more granular control over signature verification during task execution. - `0`: No mock (default behavior) - `1`: Requires a 'magic signature' to bypass verification - `2`: Always considers signatures valid This change is primarily to support parachain development, enabling the `BlockBuilder_apply_extrinsic` call to bypass signature checks for inherent extrinsics. This is crucial for allowing parachains to process faked relay chain data, such as validation data with synthetic descendant headers, without failing signature verification.
xlc
force-pushed
the
support-cumulus-consensus
branch
from
086d6a8 to
4ba653b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes introduce a flexible signature mocking mechanism, which is well-implemented on the Rust side. However, in the TypeScript code, there are significant type-safety issues with the use of any for relayParentDescendants, accompanied by a comment that indicates uncertainty about the code's correctness. This could lead to runtime errors and makes the code difficult to maintain.
ermalkaleci
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a more flexible signature mocking mechanism to support Cumulus-based consensus for parachains. This is primarily required to apply inherents that contain mock relay-chain data, a key step in parachain block production during local testing.
Changes
mock_signature_hostparameter in the WASM executor has been changed from abooleanto au8to support three distinct modes:0: No mocking (default behavior).1: Mocking is enabled but requires a "magic signature" (maintains previous behavior).2: All signature verifications are bypassed and always considered valid.BlockBuilder_apply_extrinsic, the new "always valid" (mode2) signature mocking is now used. This allows theparachainSystem.setValidationDatainherent to work with mock relay-chain headers without failing signature checks.setValidationDatahas been updated to correctly construct and handle mockrelayParentDescendants.newHeaderlogic in the block builder has been refactored to robustly handle various consensus engine digest items.Closes #975