Update shell scripts to improve consistency #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbainbridge
changed the title
joshbainbridge
force-pushed
the
fix-scripts-shebang
branch
from
da7f8b6 to
355f6a7
Compare
Shell scripts do not have a consistent shebang. Firstly they don't reference the environment bash, which could be different depending on the system. It would be better to enforce that the bash accessed was that provided by the Nix flake. Secondly the shebang should be the first line in a file. Resolve both of these issues, and verify that all scripts continue to function. Signed-off-by: Josh Bainbridge <josh.bainbridge@gmail.com>
joshbainbridge
force-pushed
the
fix-scripts-shebang
branch
from
355f6a7 to
752d50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell scripts do not have a consistent shebang. Firstly they don't reference the environment bash, which could be different depending on the system. It would be better to enforce that the bash accessed was that provided by the Nix flake. Secondly the shebang should be the first line in a file.
Resolve both of these issues, and verify that all scripts continue to function.