Start using Nix for consistency on CI #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbainbridge
force-pushed
the
cachix-ci
branch
2 times, most recently
from
01bdcec to
aa4d0dc
Compare
joshbainbridge
force-pushed
the
cachix-ci
branch
2 times, most recently
from
aceac04 to
45f1484
Compare
After initial exploration done on '9756110' the conclusion was that there were a few blocker preventing us from effectively using Nix on the GitHub CI. Re-visiting this after recent updates, it is now much more viable to leverage Nix in the CI for consistent testing. This commit does not deploy Nix for all CI build stages, but it does for all test jobs. This allows us to drive the clang-tools version from the locked Nix environment, as opposed to the variable versions used on the GitHub runners. We then get a bit more compiler coverage on the later jobs, although this might also get moved over in time. Updating clang-tools also meant that some tests failed. As a result, this commit also updates the code to resolve the failing tests. Signed-off-by: Josh Bainbridge <josh.bainbridge@gmail.com>
joshbainbridge
force-pushed
the
cachix-ci
branch
from
45f1484 to
995f16d
Compare
joshbainbridge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initial exploration done on 9756110 the conclusion was that
there were a few blocker preventing us from effectively using Nix on the
GitHub CI. Re-visiting this after recent updates, it is now much more
viable to leverage Nix in the CI for consistent testing.
This commit does not deploy Nix for all CI build stages, but it does for
all test jobs. This allows us to drive the clang-tools version from the
locked Nix environment, as opposed to the variable versions used on the
GitHub runners. We then get a bit more compiler coverage on the later
jobs, although this might also get moved over in time.
Updating clang-tools also meant that some tests failed. As a result,
this commit also updates the code to resolve the failing tests.