Skip to content

#686 Fix self-dependencies by making sure optional self-dependencies do not cause skips for informations dates if previous information dates had failed such dependencies. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yruslan merged 1 commit into from
Jan 19, 2026
Merged

#686 Fix self-dependencies by making sure optional self-dependencies do not cause skips for informations dates if previous information dates had failed such dependencies. #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pramen/core/src/main/scala/za/co/absa/pramen/core/pipeline/JobBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ abstract class JobBase(operationDef: OperationDef,

override val operation: OperationDef = operationDef

override val allowRunningTasksInParallel: Boolean = operationDef.allowParallel && !hasSelfDependencies
override val allowRunningTasksInParallel: Boolean = operationDef.allowParallel && !hasSelfDependencies(includeOptional = true)

override val isSelfDependent: Boolean = hasSelfDependencies
override val isSelfDependent: Boolean = hasSelfDependencies(includeOptional = false)

override def notificationTargets: Seq[JobNotificationTarget] = jobNotificationTargets

Expand Down Expand Up @@ -228,8 +228,11 @@ abstract class JobBase(operationDef: OperationDef,
}
}

private[core] def hasSelfDependencies: Boolean = {
operationDef.dependencies.exists(_.tables.contains(outputTableDef.name))
private[core] def hasSelfDependencies(includeOptional: Boolean): Boolean = {
if (includeOptional)
operationDef.dependencies.exists(_.tables.contains(outputTableDef.name))
else
operationDef.dependencies.filter(!_.isOptional).exists(_.tables.contains(outputTableDef.name))
}

private[core] def getInfoDateRange(infoDate: LocalDate, fromExpr: Option[String], toExpr: Option[String]): (LocalDate, LocalDate) = {
Expand Down
Loading