Skip to content

fix(installer): revert launcher and fix post-install extraction race condition and dependancy update #16

Merged
Aalwattar merged 3 commits intomasterfrom
chore/update-dependencies-mar-2026
Apr 1, 2026
Merged

fix(installer): revert launcher and fix post-install extraction race condition and dependancy update #16
Aalwattar merged 3 commits intomasterfrom
chore/update-dependencies-mar-2026

Conversation

@Aalwattar
Copy link
Copy Markdown
Owner

Summary

This PR stabilizes the ParrotInk update and installation process by resolving two critical failures observed in the v0.2.31/32 cycle.

Changes

  1. Reverted Updater Launcher: Reverted engine/services/updates.py to the original subprocess.Popen implementation with CREATE_BREAKAWAY_FROM_JOB. This ensures the installer launches reliably from the tray icon and isn't silently blocked by the parent process job object.
  2. Fixed Post-Install Delay: Moved the 3-second AV scan delay in parrotink.iss from the [Run] check to the ssPostInstall event. This ensures Windows Defender has time to scan the newly installed files before the application is executed, preventing "DLL not found" crashes during the first launch.
  3. Legacy Fallback: Increased the fallback wait timer to 4 seconds to protect users upgrading directly from non-PID-aware versions.
  4. Version Bump: Incremented version to 0.2.33.

Verification

  • Passed ruff, mypy, and pytest.
  • Manually verified via /SILENT installer bridge.

@Aalwattar Aalwattar merged commit cf54c34 into master Apr 1, 2026
1 check passed
@Aalwattar Aalwattar deleted the chore/update-dependencies-mar-2026 branch April 1, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant