fix(installer): address Intermittent DLL crash during in-app update#14
Merged
fix(installer): address Intermittent DLL crash during in-app update#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the "Failed to load Python DLL" crash by addressing a race condition during silent updates.
Changes:
Installer Delay: Added a 3000ms sleep in parrotink.iss specifically for silent installs to allow Windows Defender to finish scanning the binary before extraction.
Diagnostics: Enabled SetupLogging=yes for better troubleshooting in %TEMP%.
Validation Tool: Added scripts/test_installer_mode.ps1 to easily verify /SILENT vs Full Wizard modes.
Version Bump: Bounded to 0.2.32 and verified lockfile.
Verification:
Confirmed via logs that the delay correctly triggers in silent mode.
Passed local CI simulation (ruff, mypy, pytest).