Skip to content

Conversation

@clcl777
Copy link

@clcl777 clcl777 commented Oct 4, 2025

This PR implements simple input validation and type safety improvements !

  • Date validation: Validation to ensure dates are in correct YYYY-MM-DD format and not in the past
  • Trip type validation: Validation for trip types against allowed values (round-trip, one-way, multi-city)
  • Seat type validation: Validation for seat types against allowed values (economy, premium-economy, business, first)
  • Flight data validation: Check to ensure round-trip bookings have at least 2 flight segments
  • Fetch mode validation: Validation for fetch modes against allowed values
  • Data source validation: Validation for data source parameters

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Oct 4, 2025
@abhinavm24
Copy link

Hey @clcl777 can you please look at https://github.com/AWeirdDev/flights/pull/82/files
Feel free to port your validations to my pr

@abhinavm24
Copy link

also, you have to build on dev branch instead of main

@clcl777
Copy link
Author

clcl777 commented Oct 5, 2025

Okay, I see
Plz wait a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants