Enhance airport search to support multiple search criteria #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Manouchehri
commented
Jul 9, 2025
Manouchehri
commented
- Add search by airport code (e.g., GCM) - case-sensitive
- Add search by ICAO code (e.g., MWCR) - case-sensitive
- Add search by country code (e.g., KY) - case-sensitive
- Add search by city name (e.g., George Town) - case-insensitive
- Maintain backward compatibility with enum name search
- Add comprehensive test file demonstrating all search methods
- Add search by airport code (e.g., GCM) - case-sensitive - Add search by ICAO code (e.g., MWCR) - case-sensitive - Add search by country code (e.g., KY) - case-sensitive - Add search by city name (e.g., George Town) - case-insensitive - Maintain backward compatibility with enum name search - Add comprehensive test file demonstrating all search methods
dosubot
bot
added
size:L
dosubot
bot
added
size:XL
This comment was marked as outdated.
This comment was marked as outdated.
Move airports.csv to fast_flights package directory and configure pyproject.toml to include it as package data for proper distribution.
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.