Automatically sanitise team names #942
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debilski
force-pushed
the
feature/invalid-team-name
branch
3 times, most recently
from
24f2acc to
28131c7
Compare
Debilski
force-pushed
the
feature/invalid-team-name
branch
from
b965d46 to
d521951
Compare
Member
Author
|
Still undecided on: What if What if Everything else gets truncated to ASCII, whitespace removed (and if it is an empty string it becomes There is no further validation in the backend currently meaning a non- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #929, closes #943
Still needs some further test repairs and there needs to be some further validation/sanitising in the backend; currently it is just applied in
pelita-player.