Rework evaluation of formulas #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keszybz
force-pushed
the
rework-evaluation-of-formulas
branch
from
915088e to
a4dfd93
Compare
Now the command only does grading, so we don't need the subverb.
keszybz
force-pushed
the
rework-evaluation-of-formulas
branch
from
a4dfd93 to
2818b97
Compare
This gets rid of eval_formula, rank_person functions and the machinery that was only used by it. find_min_max is moved to application.py. The '_rating' suffix is dropped from the formula again. The ini files need to be adjusted accordingly.
keszybz
force-pushed
the
rework-evaluation-of-formulas
branch
from
2818b97 to
6d9dc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.