Skip to content

Verify function return type consistency across matchmaking, matchhistory, and leaderboard modules#9

Merged
ARSPFdo-2004 merged 1 commit intomainfrom
copilot/fix-matchmaking-errors
Mar 21, 2026
Merged

Verify function return type consistency across matchmaking, matchhistory, and leaderboard modules#9
ARSPFdo-2004 merged 1 commit intomainfrom
copilot/fix-matchmaking-errors

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 21, 2026

Three compile errors caused by mismatches between .c implementations and .h declarations: int return types conflicting with bool declarations for isQueueEmpty, isUserInQueue, and isStackEmpty, plus a freeLeaderboard code block placed outside any function body in leaderboard.c.

Changes

  • matchmaking.c: isQueueEmpty and isUserInQueue return bool, consistent with matchmaking.h
  • matchhistory.c: isStackEmpty returns bool, consistent with matchhistory.h
  • leaderboard.c: freeLeaderboard body is properly scoped within the function definition
// matchmaking.h
bool isQueueEmpty(MatchQueue* queue);
bool isUserInQueue(MatchQueue* queue, int user_id);

// matchmaking.c — now consistent
bool isQueueEmpty(MatchQueue* queue) { ... }
bool isUserInQueue(MatchQueue* queue, int user_id) { ... }

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Copilot AI changed the title [WIP] Fix conflicting types and undeclared identifier issues Verify function return type consistency across matchmaking, matchhistory, and leaderboard modules Mar 21, 2026
Copilot AI requested a review from ARSPFdo-2004 March 21, 2026 11:15
@ARSPFdo-2004 ARSPFdo-2004 marked this pull request as ready for review March 21, 2026 11:23
@ARSPFdo-2004 ARSPFdo-2004 merged commit 89eb9bd into main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants