Open
Conversation
To avoid undefined behavior, replace the signed "times" counter with an unsigned one. We don't need to track negative times anyway. ./core/vmpu/src/mpu_armv8m/vmpu_armv8m_unpriv_access.c: In function 'vmpu_unpriv_access': ./core/vmpu/src/mpu_armv8m/vmpu_armv8m_unpriv_access.c:126:1: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C2 -+ C1 [-Werror=strict-overflow] } ^ ./core/vmpu/src/mpu_armv8m/vmpu_armv8m_unpriv_access.c:94:10: error: assuming signed overflow does not occur when changing X +- C1 cmp C2 to X cmp C2 -+ C1 [-Werror=strict-overflow] uint32_t vmpu_unpriv_access(uint32_t addr, uint32_t size, uint32_t data)
To ensure our sanity checks stay sane, it's good to make sure we aren't invoking undefined overflow behavior. Make the compiler warn us when it attempts to take advantage of undefined overflow in optimizing.
|
In api/src/rpc2.c (commit: rpc2: Add RPC2),
Shouldn't the condition be "timeout_ms != 0" ? |
Contributor
Author
|
@p03189 No. The current API interprets a timeout of 0 as "let me know if it is done yet, without any blocking". Any other timeout value will be interpreted as "block forever until it is done". |
|
Oh, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for RPC (no gateway yet)
@AlessandroA @niklas-arm