-
Notifications
You must be signed in to change notification settings - Fork 21
Bump golangci/golangci-lint-action from 6 to 7 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump golangci/golangci-lint-action from 6 to 7 #140
Conversation
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@JonatanAntoni can this be merged? Who can review? |
|
@VladimirUmek, this is not an easy one because it requires a major update of golangci-lint which has updated the config file format and might issue lots of new warnings. I can have a look, later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request bumps golangci/golangci-lint-action from version 6 to version 7 and includes several minor refactorings and cleanups throughout the codebase. The changes primarily update output formatting, simplify test variable declarations, refactor lexing logic, adjust switch usage in the make command, and update GolangCI configuration and GitHub workflows.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/eventlist/pkg/output/output.go | Refactored conditional checks for output format using a switch statement. |
| tools/eventlist/pkg/event/event_test.go | Changed event type declarations to use type inference in tests. |
| tools/eventlist/pkg/eval/expression.go | Replaced an if-else with a switch for handling escape characters. |
| tools/eventlist/cmd/make/make.go | Updated switch usage for command processing and adjusted field access. |
| tools/eventlist/.golangci.yaml | Upgraded configuration with added linters and new exclusions. |
| .github/workflows/eventlist.yml | Updated GitHub Action version from v6 to v7. |
|
@soumeh01, looks like CodeCov doesn't work (anymore). |
|
A newer version of golangci/golangci-lint-action exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@JonatanAntoni CodeCov has stopped tokenless usage for public repos as well. I have been thinking about moving this to codeclimate as other golang repos. We need to have our repo registered at codeclimate. |
Sounds reasonable! |
Bumps golangci/golangci-lint-action from 6 to 7.
Release notes
Sourced from golangci/golangci-lint-action's releases.
... (truncated)
Commits
14814047.0.0dec74fafeat: golangci-lint v2 support (#1198)1f07148build(deps-dev): bump the dev-dependencies group with 3 updates (#1207)9938e10docs: fix checks permissions for annotations (#1204)b91d580docs: update annotation permissions (#1203)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)