Transition cleanup: making sure all fixes are in #135
Open
bryngemark wants to merge 19 commits intomasterfrom
Open
Transition cleanup: making sure all fixes are in #135bryngemark wants to merge 19 commits intomasterfrom
bryngemark wants to merge 19 commits intomasterfrom
Conversation
Collaborator
Author
|
OK so in broad strokes the changes include
|
try changing hardwired workflow path python patch version from 3.9.16 to 3.9.23 as quoted in printouts of path
Undoing previous change of hardwired path (did fix the first problem but others appeared down the road in building), trying now to instead specify the specific python version hardwired in the symlinking step in the workflow
pylint caught that getOutputBase raised a `string` directly and not an `Exception` with a log message
try using `Logger.getRootLogger` instead of `Logger_getRootLogger` after pylint check complains that the latter isn't a method in `arc`
More changes `_` to `.` in arc methods after pylint complaints
change to .Parse()
move to .Parse
move to .Parse
move to .Parse
move to .Parse
Collaborator
Author
|
Dealing with issues found by pylint job. Changed a whole lot of files to deal with an update in arc naming/structure, to go from
I thus consider this fixed up to the level that matches my insight and needs and will merge it despite the outsanding pylint check complaints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to a different machine, all local patches etc need to be ported over.
I will document what I think all these changes (some very old) do as I commit and get an overview. But they all represent the state of last we were up and running.