Skip to content

Transition cleanup: making sure all fixes are in #135

Open
bryngemark wants to merge 19 commits intomasterfrom
transitionCleanup
Open

Transition cleanup: making sure all fixes are in #135
bryngemark wants to merge 19 commits intomasterfrom
transitionCleanup

Conversation

@bryngemark
Copy link
Collaborator

Moving to a different machine, all local patches etc need to be ported over.

I will document what I think all these changes (some very old) do as I commit and get an overview. But they all represent the state of last we were up and running.

@bryngemark
Copy link
Collaborator Author

OK so in broad strokes the changes include

  • fixing image lookup in rucio, making sure we find existing ones also in the user scope, and block using already existing image names
  • making sure we can run pileup jobs on the fly too, i.e. without using input files of the sim event, but just adding pileup from an existing dataset while running sim
  • trying to fix lookup of the current jobs that the user should be able to cancel; this granularity has become too fine and so far making it much too coarse is the only way to not see too few jobs, but I don't think this is working properly yet
  • some poking around to try and read the wrapper script from the config instead of using a hardwired name but this I never got to work. Leaving my commented attempts in for future work

try changing hardwired workflow path python patch version from 3.9.16 to 3.9.23 as quoted in printouts of path
Undoing previous change of hardwired path (did fix the first problem but others appeared down the road in building), trying now to instead specify the specific python version hardwired in the symlinking step in the workflow
pylint caught that getOutputBase raised a `string` directly and not an `Exception` with a log message
try using `Logger.getRootLogger` instead of `Logger_getRootLogger` after pylint check complains that the latter isn't a method in `arc`
More changes `_` to `.` in arc methods after pylint complaints
change to .Parse()
move to .Parse
move to .Parse
move to .Parse
move to .Parse
@bryngemark
Copy link
Collaborator Author

Dealing with issues found by pylint job. Changed a whole lot of files to deal with an update in arc naming/structure, to go from
JobDescription_Parse(...) to JobDescription.Parse(...)
and Logger_getRootLogger() to Logger.getRootLogger(),
that has now removed all such complaints. What remains is

  • a few import errors in classes I don't explicitly use or depend on
  • some potential "use before define" cases hidden in if statements, where I have verified that the use cases we have will not cause any trouble (while rewriting with other conditions might, so I don't dare attempt to fix it)

I thus consider this fixed up to the level that matches my insight and needs and will merge it despite the outsanding pylint check complaints.

@bryngemark bryngemark marked this pull request as ready for review October 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant