Skip to content

Draft: Added logic for counter and account lock #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mjiori wants to merge 1 commit into
base: qa
Choose a base branch
from
Draft

Draft: Added logic for counter and account lock #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions web/webui/two_factor_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,29 @@ func UserTwoFactorVerify(c *gin.Context) {
return
}
if !tokenIsValid {
// TODO: increment failed login attempt count
// User model needs FailedLogins and LockoutUntil.
// Then we need logic to enforce the lockout.
msg := "Backup code is incorrect. Try again."
if method == constants.TwoFactorSMS {
msg = "One-time password is incorrect. Try again."
}

// TODO: increment failed login attempt count
// User model needs FailedLogins and LockoutUntil.
// Then we need logic to enforce the lockout.

// user.FailedLogins++
// if user.FailedLogins == constants.MaxFailedLoginsBeforeCooldown - 1 {
// msg = "Last attempt before cooldown period is enforced."
// } else if user.FailedLogins == constants.MaxFailedLoginsBeforeCooldown {
// msg = "Too many failed logins. Cooldown is enforced."
// user.CooldownUntil = now + constants.AccountCooldownTimePeriod
// } else if user.FailedLogins == constants.MaxFailedLoginsBeforeLockout - 1 {
// msg = "Last attempt before account locked."
// } else if user.FailedLogins == constants.MaxFailedLoginsBeforeLockout {
// msg = "Too many failed logins. Account has been locked for your security. Contact help@aptrust for help."
// user.IsLockout = true
// }
// user.Save()

req.TemplateData["flash"] = msg
c.HTML(http.StatusBadRequest, "users/enter_auth_token.html", req.TemplateData)
} else {
Expand Down