Updated NSQ and made changes to stats parsing for the new version#186
Open
Updated NSQ and made changes to stats parsing for the new version#186
Conversation
diamondap
reviewed
Dec 17, 2025
Member
diamondap
left a comment
There was a problem hiding this comment.
This has one failing test in the end-to-end tests.
--- FAIL: TestEndToEnd (0.20s)
helpers_test.go:183:
Error Trace: /Users/diamond/aptrust/preservation-services/e2e/helpers_test.go:183
/Users/diamond/aptrust/preservation-services/e2e/helpers_test.go:155
/Users/diamond/aptrust/preservation-services/e2e/helpers_test.go:68
/Users/diamond/aptrust/preservation-services/e2e/e2e_test.go:55
/Users/diamond/aptrust/preservation-services/e2e/e2e_test.go:42
Error: Expected nil, but got: &json.UnmarshalTypeError{Value:"object", Type:(*reflect.rtype)(0x102fa3e20), Offset:299, Struct:"ChannelStats", Field:"topics.channels.clients"}
Test: TestEndToEnd
Contributor
Author
|
I was able to fix the failing test issue by pulling in the new data structures from NSQ 1.3 into our NSQClient. Not ideal because we'll need to make changes to our client every time we update NSQ, but it will address the issue. All tests passing. |
diamondap
approved these changes
Feb 20, 2026
Member
diamondap
left a comment
There was a problem hiding this comment.
This looks good. Feel free to merge when appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades NSQ 1.2.0 -> 1.3.0
Ingest completed successfully in interactive mode. The only breaking changes found were related to a new data structure for stats reporting, which is fixed in this PR.