Open
Conversation
khloke
approved these changes
Nov 20, 2017
Now that the application does not signal it is healthy until the inital data load has completed, more time needs to be allowed for startup.
This reverts commit a5210d0.
Logs were complaining that no task scheduler bean was available.
jimvella
reviewed
Dec 11, 2017
| @@ -105,10 +110,19 @@ private void buildTree() | |||
| } | |||
|
|
|||
| @PostConstruct | |||
There was a problem hiding this comment.
Note that spring says @transactional should not be relied upon in @PostConstruct as the proxy may not be fully initialised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is probably a nice property to have in order to avoid returning responses based on partially loaded data whilst the data is still being loaded.
Also this change results in @transactional now being applied, though I haven't thought of a reasonable way to test this. The transaction belongs to RipeDbLoader, but whether it's applied is a function of how it is called (i.e. whether the call can be intercepted by a dynamic proxy). So it can really only be integration tested in the context where its called. Alternatives would be to refactor to a TransactionTemplate which isn't dependent on dynamic proxies, or to just not test.