-
Notifications
You must be signed in to change notification settings - Fork 26
Edits in Chapters 1-4 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Finishes edits and vshifts of chapters 1 and 2. Still some minor tweaking to do.
|
I'm having some trouble tracking all of the changes.
(Also, the copied versions had a lot of new, extraneous whitespace that made it hard to compare.) |
|
Yes, I am sure this pull request is a mess, much of it due to my status as a git noob. I can redo it in a cleaner way if necessary. Problems I foresaw once I committed:
Is it better if this pull request is cancelled and I:
Sorry for the trouble. |
|
I can't complain about large pull requests, considering some of the ones I have sent! Only start over if it's easier for you. Otherwise, if you can revert the apex.ptx and chapter files, and clean up some of the whitespace, I should be able to work through the rest. |
Edits sections that had comments or extraneous whitespace
|
I didn't officially "revert" apex.ptx and chapter files back to the original, but I did restore them to their original state and re-committed them in commit "fixes apex.ptx and chptrs 1 & 2": (7be3a90) I edited sections to remove most content that I commented out in "fixes sections": If I need to adopt a more git-official method, let me know. One of the most confusing forms of edits is where certain figures needed to be moved before/after certain paragraphs so that they appear on the proper page. So if it looks like I deleted figures, it's because of that. |
|
I added a few other changes to the section on basic derivative rules. The pagebreak element should probably not go inside a paragraph, etc. A couple of questions for you about changes to the placement of figures, changes to vshifts, etc.:
(I could use versioning for this, and have one set of vshifts for videos, and one for no videos, but it would require duplicating half the figures in the book, so I can put one in the |
|
0. I wasn't sure where the pagebreak command should go. It seemed to me
that this command and the enlargethispage command acted differently; one
seemed to work better inside a paragraph and one didn't. But I could be
wrong, and I'm fine leaving them both outside of paragraphs.
1. Ugh, no, I hadn't thought of the inline nature of the graphics. I'll
have to go back and look at instances where I moved them. I *think* I only
moved them from one side of a paragraph/thm/def to the other, but I could
be wrong. This was only done when there was an automatic
pagebreak occurring, and maybe I can work around it by inserting a
pagebreak command.
2. Ugh, no, I wasn't looking at the version with the QR codes. I can
restart from Chptr 1 and put the codes in and see how things fit around
them.
This is for sure a stress-test of PreTeXt. There are several competing
desires for content and its placement. My school may be backward, but few
of my students (and colleagues) use the website and most use a printed
text, though some prefer the pdf. That's why my focus is always on the
printed version.
…On Thu, Aug 1, 2024 at 1:03 PM Sean Fitzpatrick ***@***.***> wrote:
I added a few other changes to the section on basic derivative rules.
The pagebreak element should probably not go inside a paragraph, etc.
A couple of questions for you about changes to the placement of figures,
changes to vshifts, etc.:
1. When you move a figure, will the new location still make sense if
the figure is inline? We only put figures in the margin for PDF output.
Probably 95% of students (or more) use the HTML version of the book. Very
few are interested in PDF. We get only a handful of orders for print copies
every year in our bookstore. So I think it's important not to change
anything that compromises the HTML output.
2. Are you using the verison with or without the QR codes for videos?
If the new locations overlap with the QR codes, and there isn't room for me
to move the QR codes so they fit, I'll have to do the figure placement all
over again.
(I could use versioning for this, and have one set of vshifts for videos,
and one for no videos, but it would require duplicating half the figures in
the book, so I can put one in the video component, with one vshift, and
another in the novideo component, with a different vshift.)
—
Reply to this email directly, view it on GitHub
<#311 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABT5OF2N7SPR47PVYQASEALZPJS4PAVCNFSM6AAAAABLYV5S5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRTGU2DAOBQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I think a page break should go between paragraphs, the same as it does in LaTeX. If the enlarge page command works better elsewhere, that's ok. (In LaTeX I don't think I've ever put it in without line breaks on either side of it.) Have your students been given the option of the online version of the book? I can understand preferring a hard copy, but I'd be surprised if anyone chose electronic PDF over HTML. I think people in some places are being pushed to move to HTML to comply with accessibility requirements. But you also get nice perks like interactive features. |
|
I've just figured out that you're not intentionally adding most of the whitespace changes. Can you change your settings to use 2 spaces for indentation instead of a tab? If you make that change and save your files, it should fix most of the whitespace problems, I think. If you are using VSCode, use |
|
I made a few changes that were easy to make myself. An earlier comment explains how to fix the whitespace. Other than that, I think this is OK, pending confirmation that the changes are compatible with the HTML output and including video QR codes. |
|
I fixed my tab / 2 spaces issue -- I think. We'll see how it looks going forward. |
| <md> | ||
| <mrow>\amp\lzoo{x}{f(x)g(x)} = \lim_{h\to0} \frac{f(x+h)g(x+h)-f(x)g(x)}{h}</mrow> | ||
| <mrow>\lzoo{x}{f(x)g(x)} \amp= \lim_{h\to0} \frac{f(x+h)g(x+h)-f(x)g(x)}{h}</mrow> | ||
| <mrow>\amp \text{ (now add 0 to the numerator) }</mrow> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the alignment tab here is going to cause a bunch of overfull hboxes.
That will be a problem if this ends up on an odd-numbered page, I think.
And it means that the equations won't fit in HTML: a horizontal slider will be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe even pages, not odd, since there's nothing in the margin there.
|
About the font/smallcaps/init issue. If there is nothing better to do for PTX at large at this time, you could use the custom XSL that this project already has to change how an |
|
I think I will override the default (which seems questionable, IMO -- I've never seen something like PDF in small caps). I got the Latte font working on my computer, but I don't want our PDF build to depend on installing some font from source from an 8 year old software repo. Probably Greg doesn't want that, either. |
|
@APEXCalculus I will have time this month to return to this. If you would like to connect one day to go through everything, let me know! Regarding placement of margin figures in the PDF: why don't we get figures and asides where you want them, and then it'll be my problem to work out how to fit the video QR codes around them. |
| </li> | ||
| </ol> | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change here is to move the figure from the statement of the example to the solution.
Is this being done for page-fitting reasons, or semantic reasons? Semantically, it seems like the figure should be part of the statement. (Note that the statement includes the sentence "The graph in Figure (blah) demonstrates why this is often called a step function.")
We can move the figure into the solution, but then we should either delete this sentence, or move it into the solution. Keep in mind that in HTML (which is the version used by 95% of students), the solution is hidden until they click to reveal it. So they will read the statement of the example, and see a reference to a figure that initially doesn't appear to exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made that change 8+ months ago. I no longer remember why. :)
I was working on figures in the margins, so it would have moved in order to fit on the page better. For sure, it belongs with the question statement, not just the solution. I'd ignore this change and figure out the print version placement later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess was that you wanted the image to move to another page :-)
I'm going through and adding all the non-cosmetic changes on a branch. We can get those in, build the PDF, and then worry about image placement.
| <introduction> | ||
| <p> | ||
| An F-22 aircraft is flying at | ||
| An F-22 aircraft is flying at <m><var name="$spd"/>\,\text{mph}</m> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The webwork variable $spd is already a number with units. This will result in a display like 530 mph mph.
Non-figure edits from PR #311
Mostly the edits are the shifts in figures.
Other edits are made too, changing some wording in places. (Some key ideas, definitions, asides are edited.)