Fix for LGS uplink with ShackHartmann wfs#126
Merged
andrewpaulreeves merged 2 commits intoAOtools:masterfrom May 5, 2022
Merged
Fix for LGS uplink with ShackHartmann wfs#126andrewpaulreeves merged 2 commits intoAOtools:masterfrom
andrewpaulreeves merged 2 commits intoAOtools:masterfrom
Conversation
Collaborator
|
Hi @ojdf - Was it a flip in the end? When we tried it out last time we found that it didnt' solve the issue. Or did we just flip at the wrong place? Either way - quick check before I merge - the LGS example now runs properly? |
Collaborator
Author
|
@andrewpaulreeves yeah it was a flip, but in a different place. You had the flip on the LGS PSF before the convolution, which was correct but the subaps were still flipped so the slopes were backwards. What I've done is get rid of the flip before the convolution then apply it to the subaps after convolution with the LGS PSF. The LGS-uplink example now runs properly and I've changed the config file to use the non-legacy Shack Hartmann. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for LGS uplink with using
ShackHartmannwfs class. This fixes the backwards slopes issue whenuplink=True, so the non-legacy version can be used. Also changed the example config file to useShackHartmanninstead ofShackHartmannLegacy.I note that one of the changes (not flipping LGS psf) was also implemented in #98