Skip to content

Conversation

@ayaan-mirza7
Copy link

@ayaan-mirza7 ayaan-mirza7 commented Dec 22, 2025

Ran the project locally
Navigated to /projects
Confirmed that all project links (except OpenChat) are now clickable and open their repositories in a new tab

Summary by CodeRabbit

  • Bug Fixes

    • Project card links are now clickable anchors that open external projects in a new tab, improving click targets and accessibility.
  • Style

    • Minor markup and styling consolidations for more consistent card title and layout rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 22, 2025

@ayaan-mirza7 is attempting to deploy a commit to the AOSSIE Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

Updated a single JSX file to modify the Cards component: removed a useRouter() call, converted a paragraph-based project link into an anchor (<a>) that wraps the LinkIcon and label with href, target="_blank", and rel="noopener noreferrer", and adjusted related JSX/styling.

Changes

Cohort / File(s) Summary
Project Cards — link and markup updates
src/pages/projects.jsx
Removed useRouter() usage; replaced a <p>-based project link with an <a> anchor wrapping the icon and label; added href, target="_blank", and rel="noopener noreferrer"; consolidated sx/className styling and cleaned JSX whitespace/closing tags.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify href value and intent for opening in a new tab
  • Confirm rel="noopener noreferrer" is present and correct
  • Check keyboard and screen-reader accessibility for the new anchor
  • Validate hover/focus styling and layout after sx/className changes

Poem

🐰 I hopped from paragraph to link so spry,
A tiny anchor to open the sky,
With a click it leaps to a brand-new tab,
Safe and tidy — no router to nab. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding an anchor tag to project links. It is concise, clear, and reflects the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ayaan-mirza7
Copy link
Author

Hi @team, the Vercel deployment check is waiting for authorization. Could someone approve it so the preview can run? Thanks!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/pages/projects.jsx (2)

11-11: Remove unused import.

The useRouter import is no longer used after removing the router logic from the Cards component.

🔎 Proposed fix
-import { useRouter } from 'next/router';

79-87: Consider adding an indication that the link opens in a new tab.

For better accessibility and user experience, inform users that clicking the link will open a new tab. This can be done with an aria-label attribute or visible text.

🔎 Proposed fix with aria-label
 <a
   href={project.link.href}
   target="_blank"
   rel="noopener noreferrer"
+  aria-label={`${project.link.label} (opens in new tab)`}
   className="relative z-10 mt-6 flex text-md font-semibold font-mono text-zinc-600 dark:text-zinc-200 hover:text-[#00843D] dark:hover:text-yellow-400"
 >
   <LinkIcon className="h-6 w-6 flex-none scale-110" />
   <span className="ml-2">{project.link.label}</span>
 </a>
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5b2b6a and 521f8fe.

📒 Files selected for processing (1)
  • src/pages/projects.jsx
🔇 Additional comments (1)
src/pages/projects.jsx (1)

79-87: Good security implementation with rel="noopener noreferrer".

The anchor tag correctly includes rel="noopener noreferrer" with target="_blank", which prevents potential security vulnerabilities like tabnabbing.

@ayaan-mirza7
Copy link
Author

i have my code different changes but why these bots are showing my changes as wrong in my code.
my code is different and theres is different means which i commited is different and what bots are displaying is different code.
please help as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant