-
Notifications
You must be signed in to change notification settings - Fork 314
Added anchor tag successfully and tested locally #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@ayaan-mirza7 is attempting to deploy a commit to the AOSSIE Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughUpdated a single JSX file to modify the Cards component: removed a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @team, the Vercel deployment check is waiting for authorization. Could someone approve it so the preview can run? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/pages/projects.jsx (2)
11-11: Remove unused import.The
useRouterimport is no longer used after removing the router logic from the Cards component.🔎 Proposed fix
-import { useRouter } from 'next/router';
79-87: Consider adding an indication that the link opens in a new tab.For better accessibility and user experience, inform users that clicking the link will open a new tab. This can be done with an
aria-labelattribute or visible text.🔎 Proposed fix with aria-label
<a href={project.link.href} target="_blank" rel="noopener noreferrer" + aria-label={`${project.link.label} (opens in new tab)`} className="relative z-10 mt-6 flex text-md font-semibold font-mono text-zinc-600 dark:text-zinc-200 hover:text-[#00843D] dark:hover:text-yellow-400" > <LinkIcon className="h-6 w-6 flex-none scale-110" /> <span className="ml-2">{project.link.label}</span> </a>
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/projects.jsx
🔇 Additional comments (1)
src/pages/projects.jsx (1)
79-87: Good security implementation withrel="noopener noreferrer".The anchor tag correctly includes
rel="noopener noreferrer"withtarget="_blank", which prevents potential security vulnerabilities like tabnabbing.
|
i have my code different changes but why these bots are showing my changes as wrong in my code. |
Ran the project locally
Navigated to /projects
Confirmed that all project links (except OpenChat) are now clickable and open their repositories in a new tab
Summary by CodeRabbit
Bug Fixes
Style
✏️ Tip: You can customize this high-level summary in your review settings.