Fix/recursive logging handler #952
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSIE-Org#946 - Add PKGBUILD for binary package installation from releases - Add PKGBUILD-git for building from source - Add pictopy.install for post-install hooks - Add .SRCINFO metadata file - Add publish-aur.yml workflow for automatic AUR publishing - Update build-and-release.yml to generate tar.gz for AUR - Update tauri.conf.json to build all Linux targets (deb, rpm, appimage) - Update README.md with AUR installation instructions This enables Arch Linux users to install PictoPy via: yay -S pictopy paru -S pictopy Closes AOSSIE-Org#946
- Add confirmation dialog with warning message before deleting a folder - Display folder path in the confirmation dialog - Show clear warning that the action is irreversible - Add Cancel and Delete buttons with proper styling - Disable buttons during deletion to prevent double-clicks Fixes AOSSIE-Org#939
- Create ErrorBoundary component to catch JavaScript errors - Display user-friendly fallback UI with error details - Add 'Reload Application' button to recover from errors - Add 'Try Again' button to attempt recovery without reload - Wrap main App component with ErrorBoundary in main.tsx This prevents the app from showing a blank white screen when unhandled errors occur (e.g., network failures, missing data). Fixes AOSSIE-Org#937
…Org#918 - Add recursion guard flag to InterceptHandler.emit() - Emit directly to root logger handlers instead of calling logger.log() - Skip self handler when emitting to prevent infinite loop - Fix compatibility with Python 3.12's stricter recursion handling The issue was caused by emit() calling logger.log() which triggered the same handler again, causing infinite recursion until stack overflow. Fixes AOSSIE-Org#918
Contributor
|
Warning Rate limit exceeded@hharshhsaini has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 41 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
RecursionError: maximum recursion depth exceededthat occurs during backend startup on Python 3.12.Root Cause
The
InterceptHandler.emit()method was callinglogger.log()which triggered the same handler again, causing infinite recursion until stack overflow. Python 3.12 has stricter recursion handling which surfaces this issue more clearly.Changes Made
_inside_emit) toInterceptHandler.emit()logger.log()Before
RecursionError: maximum recursion depth exceeded File ".../logging/init.py", line XXXX, in emit File ".../setup_logging.py", line 250, in emit
After
Backend starts successfully without recursion errors on Python 3.12.
Related Issue
Fixes #918