-
Notifications
You must be signed in to change notification settings - Fork 494
Feat: AppImage Release for Linux #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdded AppImage as a Linux bundle target in the Tauri configuration and introduced an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src-tauri/tauri.conf.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Tauri Build Check (ubuntu-22.04)
- GitHub Check: Tauri Build Check (windows-latest)
- GitHub Check: Tauri Build Check (macos-latest, --target aarch64-apple-darwin)
- GitHub Check: Backend Tests
🔇 Additional comments (1)
frontend/src-tauri/tauri.conf.json (1)
10-10: AppImage target successfully added to build configuration.The addition of "appimage" to the targets array correctly enables AppImage bundle generation for Linux distributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src-tauri/tauri.conf.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Tauri Build Check (ubuntu-22.04)
- GitHub Check: Tauri Build Check (windows-latest)
- GitHub Check: Tauri Build Check (macos-latest, --target aarch64-apple-darwin)
- GitHub Check: Backend Tests
🔇 Additional comments (1)
frontend/src-tauri/tauri.conf.json (1)
10-10: LGTM! AppImage target added correctly.The addition of "appimage" to the bundle targets array enables AppImage distribution for Linux alongside the existing deb package format.
| "appimage": { | ||
| "bundleMediaFramework": true, | ||
| "files": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
# Check for CI/CD workflow files
fd -type f -e yml -e yaml .github/workflows 2>/dev/null || echo "No .github/workflows found"Repository: AOSSIE-Org/PictoPy
Length of output: 88
🏁 Script executed:
# Search for any references to audio/video, media processing, or GStreamer
rg -i "audio|video|gstreamer|media|ffmpeg" --type rust --type json --type toml --type yaml --type ymlRepository: AOSSIE-Org/PictoPy
Length of output: 89
🏁 Script executed:
# Check the repository structure and look for README or documentation
git ls-files | head -20Repository: AOSSIE-Org/PictoPy
Length of output: 622
🏁 Script executed:
# Examine the tauri.conf.json file more broadly
cat -n frontend/src-tauri/tauri.conf.json | head -50Repository: AOSSIE-Org/PictoPy
Length of output: 1744
🏁 Script executed:
cat -n .github/workflows/build-and-release.ymlRepository: AOSSIE-Org/PictoPy
Length of output: 12605
🏁 Script executed:
cat -n README.md | head -100Repository: AOSSIE-Org/PictoPy
Length of output: 3075
🏁 Script executed:
# Search for any media/audio/video dependencies or references in backend configuration
rg -i "audio|video|media|gstreamer|ffmpeg" --max-count 20Repository: AOSSIE-Org/PictoPy
Length of output: 50375
🏁 Script executed:
# Check if Videos page is a stub/coming soon
cat frontend/src/pages/VideosPage/Videos.tsxRepository: AOSSIE-Org/PictoPy
Length of output: 319
🏁 Script executed:
# Check the ComingSoon component
rg -A 5 "ComingSoon" frontend/src --type tsxRepository: AOSSIE-Org/PictoPy
Length of output: 89
🏁 Script executed:
# Check AppRoutes to see if Videos uses ComingSoon
rg -B 2 -A 2 "VIDEOS|ComingSoon" frontend/src/routesRepository: AOSSIE-Org/PictoPy
Length of output: 1353
🏁 Script executed:
# Search for where ComingSoon is used
rg "ComingSoon" frontend/srcRepository: AOSSIE-Org/PictoPy
Length of output: 530
Consider deferring bundleMediaFramework until video playback is implemented.
The AppImage configuration currently bundles GStreamer with bundleMediaFramework: true, adding 15–35 MB unnecessarily. Video support in PictoPy is planned (Videos, Albums, and Memories routes show "ComingSoon" placeholders), but is not yet implemented. The application currently provides image-only features (gallery, object detection with YOLO, face recognition with FaceNet, image analysis).
The CI/CD pipeline correctly uses Ubuntu (ubuntu-22.04 in build-and-release.yml), so that requirement is met. To optimize the current bundle size, disable bundleMediaFramework now and re-enable it when video playback functionality is ready.
🤖 Prompt for AI Agents
In frontend/src-tauri/tauri.conf.json around lines 16 to 18, the AppImage config
currently sets "bundleMediaFramework": true; change that value to false (or
remove the key) to stop bundling the media framework/GStreamer in current
builds, and add a TODO comment to re-enable "bundleMediaFramework": true when
video playback features are implemented and tested.
Issue - #871
This PR implements a AppImage for release
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.