Skip to content

Conversation

@SharkyBytes
Copy link
Contributor

Closes #17

📝 Description

This pull request integrates Supabase Google OAuth authentication for the patient and therapist applications, supporting iOS, Android, and web platforms. Key changes include:

->Added Google Sign-In functionality using Supabase in both patient and therapist apps
->Implemented platform-specific authentication flows for iOS, Android, and web
->Corrected folder structure for proper package version fetching in Android setup
->Added success and error snackbars for sign-in feedback
->Implemented user metadata retrieval for personalized welcome messages
->Set up appropriate post-authentication routing for each app
->Centralized Google Sign-In logic in widgets/google_signin_button.dart for both apps
-> Removed the unnecessary assets from the assets folder
-> Added the .env.example in both the apps so it would be easier to setup

To use:
-->Set required credentials in the .env file in both the patient and therapist apps
-->Test Google Sign-In across all supported platforms

📷 Screenshots or Visual Changes (if applicable)

Patient App

Recording.2025-03-19.141837.mp4

Made similar changes to therapist app too

Authentical Table in Supabase

image

✅ Checklist

  • I have read the contributing guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if applicable).
  • Any dependent changes have been merged and published in downstream modules.

@SharkyBytes
Copy link
Contributor Author

Hey @mdmohsin7! I’ve implemented everything to the best of my knowledge. Could you please review it and let me know if anything is missing?

@SharkyBytes SharkyBytes force-pushed the feat/auth-setup-patient-therapist-apps branch from 26b8f83 to 963b497 Compare March 20, 2025 10:08
Copy link
Member

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the logic to providers for both the apps please

@SharkyBytes
Copy link
Contributor Author

Hey @mdmohsin7! Did the requested changes. PTAL

@mdmohsin7
Copy link
Member

Pls do not use BuildContext in providers. The state and the logic should not depend on each other. And it is a good practice to keep the separation

@SharkyBytes SharkyBytes requested a review from mdmohsin7 March 21, 2025 04:58
@SharkyBytes
Copy link
Contributor Author

Pls do not use BuildContext in providers. The state and the logic should not depend on each other. And it is a good practice to keep the separation

Yeah, @mdmohsin7, that makes sense! I've now separated the logic and handled UI navigation in a separate file. PTAL

@mdmohsin7
Copy link
Member

@khanjasir90 since auth is a requirement for your assigned issue, can you pls test it once to confirm if everything works for you as well? Once done pls lmk and I'll review the code and will merge the PR

@khanjasir90
Copy link
Contributor

@khanjasir90 since auth is a requirement for your assigned issue, can you pls test it once to confirm if everything works for you as well? Once done pls lmk and I'll review the code and will merge the PR

Sure

@khanjasir90
Copy link
Contributor

@mdmohsin7 auth works fine in ios.
just a thing that REVERSED_CLIENT_ID has been hardcoded in info.plist file. this needs to be removed.

@mdmohsin7
Copy link
Member

@SharkyBytes pls resolve the conflicts

@SharkyBytes
Copy link
Contributor Author

Hey @mdmohsin7 Can you please check it now?

@mdmohsin7 mdmohsin7 merged commit 40d03af into AOSSIE-Org:main Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Google OAuth with Supabase in both apps

3 participants