Add support for Apple gain maps (iPhone jpegs) #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These use a different XMP syntax on the gain map image, and do not carry XMP on the main image. Moreover, the alternate headroom may not be present in the XMP, in which case it's read from the Apple Maker Notes in Exif.
maryla-uc
force-pushed
the
applegainmap
branch
from
bcf5b53 to
dc93c08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These use a different XMP syntax on the gain map image, and do not carry XMP on the main image.
Moreover, the alternate headroom may not be present in the XMP, in which case it's read from the Apple Maker Notes in Exif.
Add a --yuv-gain-map to set the gain map pixel format (chrome subsampling). This is useful because Apple gain maps are grayscale, and Chrome currently has a bug where grayscale gainmaps are ignored https://g-issues.chromium.org/issues/472455759
#2944