-
Notifications
You must be signed in to change notification settings - Fork 59
Updated Dead PMT list (data and MC) #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add offline / dead PMTs
Add info about ApplyDeadMask
ApplyDeadMask info for TreeMaker
Given the tool fetches from Detector.h, need to use "detectorstatus" rather than "channelstatus"
Seems like the goto is illegal because goto skip_channel skips SPE_available’s initialization. Declare it first.
forgot to change this to detectorstatus
jminock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
There's just one more change i would like to make to the TreeMaker - currently it is not masking out the clustered |
Final modification - remove hits from being included in the cluster tree
|
alright all good. |
|
|
Describe your changes
As discussed in PR #357, there were a few PMTs that were dead/inactive in the data which I added to the mask file to omit them for MC. I took a deeper dive (see docdb link below) at the PMT behavior over time (FY22 - FY25), and have since identified more faulty / poor performing PMTs. Those should be masked out from both the data and MC moving forward.
To do this in the data, we can update the
FullTankPMTGeometry.csvand set thedetector_statusto OFF. When thePhaseIIADCHitFindertool looks for pulses, it fetches the detector status through the DataModel, and ignores PMTs that are designated as OFF. I have also added that check to theClusterFinderandPhaseIITreeMakertool (with a configuration to do so) to retroactively apply the mask since the data already processed will not have the updated dead PMT IDs. This allows analyzers flexibility to mask out PMTs depending on the data epoch.To do this in the MC, we just add the IDs to the dead mask that is read in by
LoadWCSim, which will not pass any MC hits from that channel to downstream tools. This is only necessary if you are using the parametric model, asPMTWaveformSiminterfaces with the hit finding tools and is done the same as the data.Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
Please refer to these slides for more details.