Improves Space-Track API interaction

[zfhassaan]

Bug Fix (#5 (comment))

Refactors the code to handle Space-Track API authentication and data retrieval more robustly. Adds error handling and improves the clarity of the code. The changes ensure a more reliable and efficient interaction with the Space-Track API.

Update ( 09-12-2025 ):

Release Notes

Overview

This release introduces significant improvements to SatIntel, including enhanced security, interactive satellite search capabilities, favorites management, comprehensive test coverage, and better user experience.

---

New Features

1. Interactive Satellite Search & Filtering

Location: osint/osint.go:SelectSatellite()

• Search Functionality:

  • Search satellites by name (case-insensitive partial matching)
  • Filter by country code (e.g., US, RU, CN)
  • Filter by object type (PAYLOAD, ROCKET BODY, DEBRIS, UNKNOWN, TBA)
  • Filter by launch year

• Pagination:

  • Navigate through results with Previous/Next page controls
  • 20 results per page
  • Page indicators showing current page and total results

• Enhanced Display:

  • Shows satellite name, NORAD ID, country, and object type
  • Interactive search menu before displaying results
  • "New Search" option to modify filters without exiting

Technical Details:

• Client-side filtering for name searches (fetches up to 500 results)
• Server-side filtering for country, object type, and launch year
• Efficient caching of filtered results for better performance

---

2. Save/Load Favorites

Location: osint/favorites.go

• Favorites Management:

  • Save frequently accessed satellites to favorites
  • Quick access to favorites from satellite selection menu
  • View all favorites with details (name, NORAD ID, country, type, added date)
  • Remove individual favorites
  • Clear all favorites with confirmation

• Storage:

  • JSON file storage in ~/.satintel/favorites.json
  • Automatic directory creation
  • Prevents duplicate favorites

• Integration:

  • "⭐ Select from Favorites" option at start of satellite selection
  • Option to save satellite to favorites after selection
  • "⭐ View Favorites" option in search results navigation

---

3. Enhanced Security Features

Password Masking

Location: main.go:readPassword()

• Password input now displays asterisks (*) instead of being completely invisible
• Provides visual feedback while maintaining security
• Proper backspace handling
• Cross-platform terminal support

Input Sanitization

Location: osint/tleparser.go:validateFilePath()

• File Path Validation:
  • Prevents directory traversal attacks (blocks ../, ..\, etc.)
  • Validates path format (empty paths, null bytes, excessive length)
  • Checks for double slashes/backslashes
  • Verifies file exists and is not a directory before opening
  • Maximum path length enforcement (4096 characters)

API Key Validation

Location: main.go:validateAPIKeyFormat(), validateCredentials()

• Format Validation:

  • Length checks (3-512 characters)
  • Character validation (no newlines, tabs, or carriage returns)
  • Specific validation for Space-Track credentials
  • Specific validation for N2YO API keys

• Connection Testing:

  • Tests Space-Track API connection on startup
  • Tests N2YO API connection on startup
  • Provides clear error messages for invalid credentials
  • Validates credentials before use

---

Improvements

1. Environment Variable Management

• .env File Support:
  • Load credentials from .env file automatically
  • Graceful fallback to manual input if .env not found
  • Supports quoted values and comments in .env files
  • Clear error messages for different failure scenarios

2. Error Handling

• Improved error messages throughout the application
• Context-specific error messages with suggestions
• Better validation feedback for user inputs
• Graceful handling of API failures

3. TLE Parsing Robustness

• Enhanced Validation:

  • Lenient field count validation (minimum 4 for line 1, 3 for line 2)
  • Comprehensive bounds checking before array accesses
  • Better handling of variable field counts
  • Improved error messages with diagnostic information

• Bug Fixes:

  • Fixed panic when TLE data has insufficient fields
  • Fixed validation to check data before split operation
  • Added validation in TLETextFile() and TLEPlainString() functions

4. HTTP Client Improvements

• Session Management:

  • Cookie jar implementation for persistent Space-Track sessions
  • Fixed 401 Unauthorized errors after login
  • Proper session cookie handling

• Error Handling:

  • Fixed nil pointer dereference in HTTP error handling
  • Early returns after HTTP errors
  • Better error messages for network failures

5. Code Quality

• Replaced deprecated io/ioutil with os and io packages
• Removed redundant return statements
• Improved code documentation with natural language godoc comments
• Better code organization and structure

---

Testing

Test Coverage

Main Package Tests (main_test.go, main_apivalidation_test.go)

• Password Field Detection: 11 test cases
• Environment File Loading: 7 test cases + 4 edge cases
• API Key Format Validation: 27+ test cases
• Credential Validation: Multiple test scenarios
• Benchmark Tests: Performance testing for key functions

OSINT Package Tests (osint_test.go, osint/tleparser_test.go, osint/favorites_test.go)

• NORAD ID Extraction: 8 test cases
• String Formatting: 4 test cases
• Query Building: 7 test cases
• Name Filtering: 6 test cases
• File Path Validation: 18 test cases + 5 edge cases
• Favorites Management: 7 test functions covering all operations
• Benchmark Tests: Performance testing

CLI Package Tests (cli/cli_test.go)

• File reading tests
• Banner display tests

Test Runner

• Centralized test runner (run_tests.go)
• Module-based testing organization
• Options for coverage, verbose output, and benchmarks
• Easy to add new test modules

Total Test Coverage: 100+ test cases across all modules

---

Bug Fixes

1. TLE Parsing Panic: Fixed slice bounds out of range errors when parsing TLE data with insufficient fields
2. HTTP Session Management: Fixed 401 Unauthorized errors by implementing proper cookie jar
3. Nil Pointer Dereference: Fixed panics in HTTP error handling and file operations
4. NORAD ID Extraction: Fixed bug where satellite name was extracted instead of NORAD ID
5. String Formatting: Fixed panic with negative repeat count for very long inputs
6. File Path Validation: Added missing validation in TLETextFile() function
7. TLE Validation: Added validation checks in TLETextFile() and TLEPlainString() functions

---

Security Improvements

1. Test Credentials: Replaced potentially misleading test values with clearly fake credentials (fake_test_* prefix)
2. Input Validation: Comprehensive file path validation to prevent directory traversal attacks
3. Password Masking: Enhanced password input with asterisk display
4. API Key Validation: Format validation and connection testing for all API credentials
5. No Hardcoded Secrets: All credentials loaded from environment variables or .env files

---

Migration Guide

For Existing Users

1. Environment Variables:

   • No changes required - existing environment variables continue to work
   • New .env file support is optional

2. Favorites:

   • Favorites are stored in ~/.satintel/favorites.json
   • Automatically created on first use
   • No migration needed

3. API Credentials:

   • Credentials are now validated on startup
   • Invalid credentials will show clear error messages
   • Connection tests ensure credentials work before use

Breaking Changes

• None - all changes are backward compatible

---

Dependencies

New Dependencies

• None - all features use existing dependencies

Updated Dependencies

• All dependencies remain the same
• No breaking changes in dependencies

---

Performance Improvements

• Efficient caching of filtered satellite results
• Optimized API query building
• Reduced redundant API calls
• Better memory management in TLE parsing

---

Changelog Summary

Added

• Interactive satellite search with filters
• Pagination for search results
• Favorites save/load functionality
• File path validation
• API key format validation
• Connection testing for APIs
• tests for all modules
• Test runner script to run tests for all modules
• .env file support
• Password masking with asterisks

Changed

• Enhanced TLE parsing validation
• Improved error messages
• Better HTTP session management
• Replaced deprecated io/ioutil package
• Improved code documentation

Fixed

• TLE parsing panics
• HTTP 401 errors after login
• Null pointer dereferences
• NORAD ID extraction bug
• String formatting panics
• Missing validation in TLE parser functions

Security

• Input sanitization for file paths
• Test credentials clearly marked as fake
• Enhanced password input security
• API credential validation

[gitguardian]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

---

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

[zfhassaan]

Hey @ANG13T Are you still maintaining this repository? Thanks.