Skip to content

Remove outdated menu-compressed class #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AMaestroG wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove outdated menu-compressed class #1334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions docs/style-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,6 @@ secciones realicen una animación de desplazamiento fluida.
## Menú móvil

Los paneles de menú deslizante utilizan la clase `.open` para mostrarse y
desaparecer al quitársela. Al activarse, `assets/js/main.js` añade la clase
`menu-compressed` al elemento `<body>` junto con `menu-open-left` o
`menu-open-right` según el lateral. Esta combinación desplaza la página y aplica
detalles en morado principal (`--color-primario-purpura`) con bordes en oro viejo
(`--color-secundario-dorado`) para resaltar el estado activo.
desaparecer al quitársela. El script `assets/js/main.js` gestiona el atributo
`aria-expanded` del botón sin modificar las clases del elemento `<body>`, de modo
que la página permanece fija cuando el menú está abierto.
2 changes: 1 addition & 1 deletion nuevaweb/dist/assets/style.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions nuevaweb/src/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,3 @@ body {
text-decoration: none;
}

body.menu-compressed {
overflow: hidden;
}
14 changes: 7 additions & 7 deletions tests/menuCompressionTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ const { launchBrowser, closeBrowser } = require('./helpers/puppeteerSetup');
await page.waitForSelector('#consolidated-menu-button');
await page.click('#consolidated-menu-button');
await page.waitForTimeout(500);
const hasClass = await page.evaluate(() => document.body.classList.contains('menu-compressed'));
if (hasClass) {
console.error('menu-compressed class should not be present');
const countAfterOpen = await page.evaluate(() => document.body.classList.length);
if (countAfterOpen !== 0) {
console.error('Body classes should remain unchanged after opening');
await closeBrowser(browser);
process.exit(1);
}
await page.click('#consolidated-menu-button');
await page.waitForTimeout(500);
const stillHasClass = await page.evaluate(() => document.body.classList.contains('menu-compressed'));
if (stillHasClass) {
console.error('menu-compressed class still present after closing');
const countAfterClose = await page.evaluate(() => document.body.classList.length);
if (countAfterClose !== 0) {
console.error('Body classes should remain unchanged after closing');
await closeBrowser(browser);
process.exit(1);
}
console.log('Menu opens without adding menu-compressed');
console.log('Menu opens without modifying body classes');
await closeBrowser(browser);
})();
4 changes: 2 additions & 2 deletions tests/menuJsToggle.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ describe('menu.js toggle behavior', () => {

btn.click()
expect(menu.classList.contains('open')).toBe(true)
expect(window.document.body.classList.contains('menu-compressed')).toBe(false)
expect(window.document.body.classList.length).toBe(0)
expect(btn.getAttribute('aria-expanded')).toBe('true')

btn.click()
expect(menu.classList.contains('open')).toBe(false)
expect(window.document.body.classList.contains('menu-compressed')).toBe(false)
expect(window.document.body.classList.length).toBe(0)
expect(btn.getAttribute('aria-expanded')).toBe('false')
})
})
3 changes: 0 additions & 3 deletions webnueva/assets/css/simple.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,3 @@ body {
font-weight: bold;
}

body.menu-compressed {
overflow: hidden;
}
1 change: 0 additions & 1 deletion webnueva/assets/js/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ document.addEventListener('DOMContentLoaded', () => {
toggle.addEventListener('click', () => {
const opened = menu.classList.toggle('open');
toggle.setAttribute('aria-expanded', opened);
document.body.classList.toggle('menu-compressed', opened);
});
});