Skip to content

Conversation

@zingale
Copy link
Member

@zingale zingale commented Jan 15, 2026

it seems to cause more problems then it fixes

it seems to cause more problems then it fixes
@zingale
Copy link
Member Author

zingale commented Jan 15, 2026

This (disabling clipping) seems to work well for a lot of problems, but for iso7 we get FPEs. I think that this is because there are some very negative mass fractions that are predicted in the nonlinear solver loop in vode_dvnlsd.H and when we call the RHS, the EOS call sees a negative $\bar{Z}$.

A robust solution might be to check the mass fractions inside that loop (around line 111) and then,
if they are negative, exit the function in the same manner we do if the matrix is singular. This will
force VODE to then try a smaller timestep.

@zingale
Copy link
Member Author

zingale commented Jan 15, 2026

The iso7 FPEs are fixed if we use the option in #1921

@zingale
Copy link
Member Author

zingale commented Jan 16, 2026

going to merge this into #1921, since I think both changes need to be done together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant