Fix get_file_name segfault: use 1-based index#25
Merged
Conversation
The C++ getFileName does file_names_[index-1], so index=0 causes unsigned underflow and a segfault. Use index=1 (first file). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_file_name(name, 0)causes a segfault because the C++ implementation uses 1-based indexing:file_names_[index-1]index=0,index-1underflows toSIZE_MAXon unsignedsize_t, causing an out-of-bounds accessassert(index <= file_names_.size())) incorrectly allowsindex=0and is stripped in release builds anywayFix
Changed
get_file_name(name, 0)toget_file_name(name, 1)in the test.The C++ side should also be hardened (bounds check instead of assert, or switch to 0-based indexing), but that's a separate change.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com