Skip to content

fix: file an issue when the milestone isn't found #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npmccallum merged 1 commit into from
Oct 15, 2025
Merged

fix: file an issue when the milestone isn't found #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,20 +251,19 @@ impl GitHub {
Ok(assets)
}

fn milestone(&self, title: &str) -> Result<u64> {
self.milestones
.get(title)
.copied()
.ok_or_else(|| anyhow::anyhow!("Milestone '{}' not found", title))
}

pub async fn report(&self, report: Report) -> Result<()> {
let report = Report {
title: report.title,
body: report.body,
labels: report.labels,
assignees: report.assignees,
milestone: report.milestone.map(|t| self.milestone(&t)).transpose()?,

// We make a best-effort attempt to add the milestone. But if the
// milestone isn't found on the repo, we still file an issue so
// that we don't lose the results of the test run.
milestone: report
.milestone
.and_then(|t| self.milestones.get(&t).copied()),
};

let url = format!(
Expand Down