-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Allow asset download from private repos #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables downloading release assets from private GitHub repositories by using asset IDs and authentication tokens, while maintaining backward compatibility for public repos via a --public flag.
Key Changes:
- Added authentication support using GitHub tokens for private repository access
- Introduced
--publicflag to preserve original public-only download behavior - Modified asset download logic to use asset ID-based URLs for private repos
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/github.rs | Added id field to Asset struct, --public flag, and helper methods for repo metadata and token access |
| src/http/server.rs | Added authentication headers to HTTP client when accessing private repositories |
| src/http/service.rs | Implemented request builder with private/public repo logic and response inspection utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fc4daae to
3994be4
Compare
3994be4 to
5836171
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5836171 to
5c78ec0
Compare
Use --public to download in a way (the old way) that only works for public repos. Resolves: AMDEPYC#18
5c78ec0 to
74dfd45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Allow asset download from private repos: use URL with asset ID, supply token, etc.
Use --public to download in a way (the old way) that only works for public repos.
Resolves: #18