Skip to content

Conversation

@markg-github
Copy link
Contributor

Allow asset download from private repos: use URL with asset ID, supply token, etc.
Use --public to download in a way (the old way) that only works for public repos.

Resolves: #18

Copilot AI review requested due to automatic review settings December 6, 2025 14:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables downloading release assets from private GitHub repositories by using asset IDs and authentication tokens, while maintaining backward compatibility for public repos via a --public flag.

Key Changes:

  • Added authentication support using GitHub tokens for private repository access
  • Introduced --public flag to preserve original public-only download behavior
  • Modified asset download logic to use asset ID-based URLs for private repos

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/github.rs Added id field to Asset struct, --public flag, and helper methods for repo metadata and token access
src/http/server.rs Added authentication headers to HTTP client when accessing private repositories
src/http/service.rs Implemented request builder with private/public repo logic and response inspection utilities

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 16, 2025 21:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Use --public to download in a way (the old way) that only works for public repos.

Resolves: AMDEPYC#18
Copilot AI review requested due to automatic review settings January 8, 2026 19:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@markg-github markg-github merged commit 8d5f0a0 into AMDEPYC:main Jan 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dispatch doesn't work with private GitHub repos

2 participants