Update ble-shelly-dw.js #147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original script won't control output 0, this fix it. suggesting to check other similar script
taulfsime
requested changes
Mar 29, 2025
Collaborator
taulfsime
left a comment
taulfsime
left a comment
There was a problem hiding this comment.
This was the condition for the actions will be hardcoded, if the script doesn't work the config parser should be checked, but not hardcoded the actions
| ) | ||
| return; | ||
| let BTHparsed = ShellyBLUParser.getData(res); | ||
| // it will not work without this!! |
Collaborator
There was a problem hiding this comment.
Actions are defined in the config located at the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original script won't control output 0, this fix it. suggesting to check other similar script