Skip to content

Resolve "missing imaginary part of phase in Fourier transforms"#557

Open
ALF-Import-Bot wants to merge 1 commit intomasterfrom
313-missing-imaginary-part-of-phase-in-fourier-transforms
Open

Resolve "missing imaginary part of phase in Fourier transforms"#557
ALF-Import-Bot wants to merge 1 commit intomasterfrom
313-missing-imaginary-part-of-phase-in-fourier-transforms

Conversation

@ALF-Import-Bot
Copy link

In GitLab by @johanneshofmann87 on Jun 12, 2025, 11:57 UTC:

Closes #313

Assignees: @johanneshofmann87

Reviewers: fassaad

Migrated from GitLab: https://git.physik.uni-wuerzburg.de/ALF/ALF/-/merge_requests/229

@ALF-Import-Bot
Copy link
Author

In GitLab by @johanneshofmann87 on Jun 12, 2025, 12:03 UTC:

added 1 commit

  • 179f424 - Fix missing i*sin(k*x) in FT_K_to_R_C,

Compare with previous version

@ALF-Import-Bot
Copy link
Author

In GitLab by @johanneshofmann87 on Jun 12, 2025, 12:05 UTC:

marked this merge request as ready

@ALF-Import-Bot
Copy link
Author

In GitLab by @johanneshofmann87 on Jun 12, 2025, 12:07 UTC:

@fassaad and @Jonas_schwab Can you please check the corrected phase factor in FT_K_to_R_C
(unused in ALF and also unused in analysis, where we use FT_K_to_R_Mat_C which already used the correct phase with imaginary parts)

@ALF-Import-Bot
Copy link
Author

In GitLab by @fassaad on Jul 21, 2025, 13:38 UTC:

requested review from @fassaad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants